Remove initial dependency to Google Maps script#107
Open
alpdeniz wants to merge 1 commit intoLogicify:masterfrom
Open
Remove initial dependency to Google Maps script#107alpdeniz wants to merge 1 commit intoLogicify:masterfrom
alpdeniz wants to merge 1 commit intoLogicify:masterfrom
Conversation
|
No one to merge it? |
|
guess not |
|
Thanks for this. We are loading the Google Maps API asynchronously via RequireJs, and I was having issues because of the initial dependency. Do you think this can be merged at some point? Will fork this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves the requirement to have Google Maps script loaded before. Enabling the picker to be initiated in later stages of the page load.