Skip to content

Conversation

@fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Dec 15, 2025

πŸ“ Moved ApplicationChecker into SignerUtils

As the class was used in both SignerETH and SignerSOL I moved the ApplicationChecker into SignerUtils pkg to avoid code duplication

❓ Context

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copilot AI review requested due to automatic review settings December 15, 2025 16:44
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner December 15, 2025 16:44
@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
device-sdk-ts-sample Ready Ready Preview, Comment Dec 16, 2025 3:25pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
doc-device-management-kit Ignored Ignored Dec 16, 2025 3:25pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

}

export class ApplicationChecker {
private isCompatible = true;
Copy link
Contributor

@aussedatlo aussedatlo Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[COULD] private isCompatible = false; and use this.isCompatible = true; if needed. In general is clearer to read without negation and you should have less impacted lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants