-
Notifications
You must be signed in to change notification settings - Fork 17
π¨ (signer-utils): Moved ApplicationChecker into SignerUtils #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
π¨ (signer-utils): Moved ApplicationChecker into SignerUtils #1193
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
e2d2edc to
680acc6
Compare
680acc6 to
57b88a7
Compare
| } | ||
|
|
||
| export class ApplicationChecker { | ||
| private isCompatible = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[COULD] private isCompatible = false; and use this.isCompatible = true; if needed. In general is clearer to read without negation and you should have less impacted lines
π Moved ApplicationChecker into SignerUtils
As the class was used in both SignerETH and SignerSOL I moved the ApplicationChecker into SignerUtils pkg to avoid code duplication
β Context
β Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
π§ Checklist for the PR Reviewers