update use of newbyteorder for newer versions of numpy#650
Merged
JoanneBogart merged 5 commits intomasterfrom Nov 18, 2025
Merged
update use of newbyteorder for newer versions of numpy#650JoanneBogart merged 5 commits intomasterfrom
JoanneBogart merged 5 commits intomasterfrom
Conversation
erykoff
approved these changes
Nov 18, 2025
Contributor
erykoff
left a comment
erykoff
left a comment
There was a problem hiding this comment.
Looks good, but I'm curious why the swapping is needed in the first place! But just fine to keep the past behavior since it does work.
Contributor
Author
|
Yes, I'm just trying to preserve old behavior; I can't say I understand it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain readers were trying to swap bytes in a manner not supported by NumPy version >= 2.0. This PR substitutes the recommended syntax.