updates for compatibility with changed DataRegistry API, making use o…#645
Merged
JoanneBogart merged 3 commits intomasterfrom Apr 16, 2025
Merged
updates for compatibility with changed DataRegistry API, making use o…#645JoanneBogart merged 3 commits intomasterfrom
JoanneBogart merged 3 commits intomasterfrom
Conversation
…f namespace as connection parameter
yymao
reviewed
Apr 15, 2025
Member
yymao
left a comment
yymao
left a comment
There was a problem hiding this comment.
Thanks @JoanneBogart. I have one minor comment inline.
Given that there are compatibility-breaking changes (although not user facing), we should at least increment the minor version number.
Simplify unnecessarily cautious code. Co-authored-by: Yao-Yuan Mao <[email protected]>
Contributor
Author
|
@yymao I agree about the version change, just wasn't sure at what stage this should be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API for connecting to the dataregistry has changed. This PR updates gcr-catalogs to be compatible with the new protocol.