Skip to content

Modernize player modules and core strictness #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utsnik wants to merge 1 commit into
base: public/9.2
Choose a base branch
from
+15 −40
Open

Modernize player modules and core strictness #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Slim/Control/Jive.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package Slim::Control::Jive;
# version 2.

use strict;
use warnings;

use POSIX qw(strftime);
use Scalar::Util qw(blessed);
Expand Down
7 changes: 2 additions & 5 deletions Slim/Player/Boom.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@ package Slim::Player::Boom;
# GNU General Public License for more details.

use strict;
use vars qw(@ISA);
use warnings;

BEGIN {
require Slim::Player::Squeezebox2;
push @ISA, qw(Slim::Player::Squeezebox2);
}
use parent qw(Slim::Player::Squeezebox2);

use Slim::Hardware::BacklightLED;
use Slim::Networking::Slimproto;
Expand Down
10 changes: 2 additions & 8 deletions Slim/Player/Disconnected.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,9 @@
package Slim::Player::Disconnected;

use strict;
use vars qw(@ISA);
use Slim::Player::Client;
use warnings;

use Slim::Display::NoDisplay;

BEGIN {
require Slim::Player::Client;
push @ISA, qw(Slim::Player::Client);
}
use parent qw(Slim::Player::Client);

sub new {
my ( $class, $id ) = @_;
Expand Down
7 changes: 2 additions & 5 deletions Slim/Player/HTTP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@
package Slim::Player::HTTP;

use strict;
use vars qw(@ISA);
use Slim::Player::Client;
use warnings;

use Slim::Display::NoDisplay;

@ISA = qw(Slim::Player::Client);
use parent qw(Slim::Player::Client);

sub new {
my ($class, $id, $paddr, $tcpsock) = @_;
Expand Down
7 changes: 2 additions & 5 deletions Slim/Player/Receiver.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@ package Slim::Player::Receiver;
# GNU General Public License for more details.

use strict;
use vars qw(@ISA);
use warnings;

BEGIN {
require Slim::Player::Squeezebox2;
push @ISA, qw(Slim::Player::Squeezebox2);
}
use parent qw(Slim::Player::Squeezebox2);

use Slim::Player::ProtocolHandlers;
use Slim::Utils::Prefs;
Expand Down
14 changes: 2 additions & 12 deletions Slim/Player/SqueezePlay.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,9 @@ package Slim::Player::SqueezePlay;
# GNU General Public License for more details.

use strict;
use vars qw(@ISA);
use warnings;

use Slim::Utils::Prefs;
use Slim::Utils::Log;

my $prefs = preferences('server');

my $log = logger('network.protocol.slimproto');
Comment on lines -17 to -22
Copy link
Member

@michaelherger michaelherger Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore these four lines. Their removal breaks LMS.


BEGIN {
require Slim::Player::Squeezebox2;
push @ISA, qw(Slim::Player::Squeezebox2);
}
use parent qw(Slim::Player::Squeezebox2);

{

Expand Down
7 changes: 2 additions & 5 deletions Slim/Player/Transporter.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ package Slim::Player::Transporter;
#

use strict;
use vars qw(@ISA);
use warnings;

BEGIN {
require Slim::Player::Squeezebox2;
push @ISA, qw(Slim::Player::Squeezebox2);
}
use parent qw(Slim::Player::Squeezebox2);

use MIME::Base64;

Expand Down
1 change: 1 addition & 0 deletions Slim/Utils/Misc.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ L<Slim::Utils::Misc> serves as a collection of miscellaneous utility
=cut

use strict;
use warnings;
use Exporter::Lite;

our @EXPORT = qw(assert msg msgf errorMsg specified dumpFiltered);
Expand Down
1 change: 1 addition & 0 deletions Slim/Web/HTTP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package Slim::Web::HTTP;
# version 2.

use strict;
use warnings;

use AnyEvent::Handle;
use CGI::Cookie;
Expand Down