Prevent {{ or }} from appearing in output#9
Open
davidlowryduda wants to merge 1 commit intoLMFDB:masterfrom
Open
Prevent {{ or }} from appearing in output#9davidlowryduda wants to merge 1 commit intoLMFDB:masterfrom
{{ or }} from appearing in output#9davidlowryduda wants to merge 1 commit intoLMFDB:masterfrom
Conversation
The output generated from `make lmfdb` is placed into the lmfdb, which
has jinja expansion. The pattern `{{` and `}}` leads to errors, as these
indicate code in jinja. This commit has the `make lmfdb` command replace
each `{{` with `{ {` and `}}` with `} }`.
davidlowryduda
added a commit
to davidlowryduda/lmfdb
that referenced
this pull request
Nov 29, 2017
The problem in LMFDB#2332 went unnoticed because of a lack of testing. This commit adds tests for the base citations page and the "How to Cite" the lmfdb page. These tests really just check that these pages exist. It also tests a specific reference in the citation list and tests for its bib entry in the associated bibliography list. This would catch the problem from LMFDB#2332. Note that I've also submitted a pull request to the LMFDB/citations repository to prevent this issue from coming up. This is LMFDB/citations#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output generated from
make lmfdbis placed into the lmfdb, whichhas jinja expansion. The pattern
{{and}}leads to errors, as theseindicate code in jinja. This commit has the
make lmfdbcommand replaceeach
{{with{ {and}}with} }.