Implement HTML renders #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add obsidian_plugin export that combines all plugins (callouts, footnotes, task lists, dollar math) for easy HTML rendering - Update README with correct HTML rendering example showing proper output - Replace TODO/FIXME comments with explanatory NOTE comments explaining technical limitations - Document blockquote wrapper limitation and suggest post-processing for accessibility - All tests passing (20/20) Changes: - mdformat_obsidian/mdit_plugins/__init__.py: Added obsidian_plugin() function - README.md: Updated HTML rendering section with correct output example - _obsidian_callouts.py: Clarified blockquote replacement limitation - _obsidian_inline_footnotes.py: Updated TODO to NOTE about implemented rendering - plugin.py: Clarified content div rendering approach
…-renders-01GRGgpEbtLuHdbNMHUkJj3H
- Register HTML renderer rules for all callout token types - Use md.add_render_rule() to properly bind renderer functions - Smart newline handling: omit newlines before inline content and closing tags - Prevents extra whitespace in rendered HTML output This properly implements HTML rendering that was previously relying on default markdown-it behavior. All 20 tests passing including: - Callout rendering with proper div structure and attributes - Foldable callouts with collapse state - Nested callouts - Inline footnotes - Task lists - Dollar math The renderer checks next token type to intelligently add/omit newlines, ensuring clean HTML output that matches expected formatting.
- Add TYPE_CHECKING imports for RendererHTML, Token, OptionsDict, EnvType - Add complete type annotations to render_callout_open and render_callout_close - Prefix unused parameters with underscore (_options, _env, _self) - Fix import order: move Callable from typing to collections.abc - Auto-format code with ruff All ruff checks now pass: - ANN202: Function return types added - ANN001: All parameter types annotated - ARG001: Unused parameters prefixed with underscore - UP035: Callable imported from collections.abc Tests: All 20 tests passing
KyleKing
deleted the
claude/implement-html-renders-01GRGgpEbtLuHdbNMHUkJj3H
branch
KyleKing
restored the
claude/implement-html-renders-01GRGgpEbtLuHdbNMHUkJj3H
branch
KyleKing
deleted the
claude/implement-html-renders-01GRGgpEbtLuHdbNMHUkJj3H
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: