upgrade examples so that they are compatible with latest react-native version#195
Open
liusy182 wants to merge 1 commit intoKureev:masterfrom
Open
upgrade examples so that they are compatible with latest react-native version#195liusy182 wants to merge 1 commit intoKureev:masterfrom
liusy182 wants to merge 1 commit intoKureev:masterfrom
Conversation
Owner
|
Hi @liusy182! Thanks for your contribution! Have you checked if it still works after this PR? |
Author
|
Hi @Kureev, I have checked all examples on iOS and they all worked. I did not check android though. |
Owner
|
Would be nice if somebody who has some time (can I ask you, @satya164?) try Android examples first before I merge it in. |
|
I'll test that tonight. BTW what do you think about migrating the example to exponent? It'll be super -easy for people to try it out then. And we don't have any native code in the repo which we need to update on RN updates. Should be easy to convert to exponent using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples were still based on older versions of react-native which is not compatible with latest versions. This PR upgrades examples so that they are compatible with current version of react-native.