Skip to content

Conversation

@esnible
Copy link
Collaborator

@esnible esnible commented Jan 22, 2026

Small fixes to make the code safer.

I found these visually. They are not detected by any existing tests, and I ran the unit tests with -count 1000 -parallel 100.

We should probably write some tests for concurrent modifications, so we can catch these problems if more are introduced.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from maleck13 January 22, 2026 17:02
@maleck13
Copy link
Contributor

I think it would also make sense to run the broker-router with the -race flag

go test -race mypkg   
$ go run -race mysrc.go 
$ go build -race mycmd 

@maleck13 maleck13 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into Kuadrant:main with commit 5c5b2e5 Jan 23, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants