refactor: migrate projects request to insomnia-api package - [INS-1874] #9574
+277
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors project-related API calls by migrating them from direct insomniaFetch usage to the centralized insomnia-api package. The migration covers team project operations (fetch, create, update, delete) and git project count reporting.
Changes:
- Migrated team project APIs (
fetchTeamProjects,createTeamProject,updateTeamProject,deleteTeamProject) to theinsomnia-apipackage - Migrated git project count update API (
updateGitProjectCount) to theinsomnia-apipackage - Updated all consumer files to use the new API functions from
insomnia-api
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/insomnia-api/src/project.ts |
Added new project API functions with typed interfaces |
packages/insomnia-api/src/index.ts |
Exported project module from package |
packages/insomnia/src/ui/organization-utils.ts |
Updated to use fetchTeamProjects from insomnia-api |
packages/insomnia/src/routes/organization.$organizationId.project.new.tsx |
Updated to use createTeamProject and updateGitProjectCount |
packages/insomnia/src/routes/organization.$organizationId.project.$projectId.update.tsx |
Updated to use createTeamProject, updateTeamProject, and deleteTeamProject |
packages/insomnia/src/routes/organization.$organizationId.project.$projectId.delete.tsx |
Updated to use deleteTeamProject |
packages/insomnia/src/models/helpers/project.ts |
Updated to use createTeamProject |
Comments suppressed due to low confidence (3)
packages/insomnia/src/models/helpers/project.ts:9
- The
insomniaFetchimport is no longer used in this file after migrating tocreateTeamProjectfrom insomnia-api. This unused import should be removed.
import { insomniaFetch } from '../../ui/insomnia-fetch';
packages/insomnia/src/routes/organization.$organizationId.project.new.tsx:11
- The
insomniaFetchimport is no longer used in this file after migrating to the insomnia-api package functions. This unused import should be removed.
import { insomniaFetch } from '~/ui/insomnia-fetch';
packages/insomnia/src/routes/organization.$organizationId.project.$projectId.update.tsx:12
- The
insomniaFetchimport is no longer used in this file after migrating to the insomnia-api package functions. This unused import should be removed.
import { insomniaFetch } from '~/ui/insomnia-fetch';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Circular References ReportGenerated at: 2026-01-19T03:28:15.492Z Summary
Click to view all circular references in PR (167)Click to view all circular references in base branch (167)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
CurryYangxx
force-pushed
the
refactor/insomnia-api
branch
from
dd98bc6 to
49e1abc
Compare
ZxBing0066
reviewed
Jan 19, 2026
| payload?: any; | ||
| } | ||
|
|
||
| export const parseInsomniaFetchError = (error: unknown) => { |
Member
There was a problem hiding this comment.
I would suggest moving this check to the insomnia-api, as it is part of the api spec. Like the following:
import {createProject, isAPIError} from 'insomnia-api'
try {
const newProject = await createProject({ ... })
} catch (e) {
if(isAPIError(e)) {
if (parsedError.name === 'FORBIDDEN') {
errMessage = 'You do not have permission to create a cloud project in this organization.';
} else if (parsedError.name === 'NEEDS_TO_UPGRADE') {
errMessage = 'Upgrade your account in order to create new Cloud Projects.';
} else if (parsedError.name === 'PROJECT_STORAGE_RESTRICTION') {
errMessage = parsedError.message ?? 'The owner of the organization allows only Local Vault project creation.';
}
throw new Error(errMessage);
}
throw e
}
ZxBing0066
reviewed
Jan 19, 2026
| this.response = response; | ||
| } | ||
| response; | ||
| payload?: any; |
Member
There was a problem hiding this comment.
Is it necessary to add this payload? I didn't find anywhere use this.
| data: { | ||
| name: project.name, | ||
| }, | ||
| const newCloudProject = await createTeamProject({ |
Member
There was a problem hiding this comment.
I think we should also update the error handling here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the following apis to the
insomnia-apipackage:Since we set
onlyResolveOnSuccessto always true when we registerfetchapi. So I changed all the error handling approaches for the places that send these requests.