Open
Conversation
Contributor
Author
|
After making this PR, I realized that for my own use, I prefer the actions to be |
Owner
|
This is a breaking change, so will merge this with z2m 3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch now sends
on_press | off_press | rotate:We could drop
brightnessfrom the press payload if that's more consistent with other devices.Separately, we can distinguish off/on based on what the switch reports, but...should we? Or should we combine them into a stateless
press? Eg, if a light changes state because of an outside service call, it becomes out of sync with this switch. This can easily be handled at the automation level, but perhaps it should be handled here.Related: Koenkk/zigbee2mqtt#28450, Koenkk/zigbee2mqtt#25538, Koenkk/zigbee2mqtt#12291