Skip to content

Add the ability to see which rule object has errored #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hlascelles wants to merge 2 commits into from
Closed

Add the ability to see which rule object has errored #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2602c25
Add the ability to see which rule object has errored
Oct 2, 2013
2815286
Moving reset
Oct 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Src/knockout.validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,9 @@
return observable.__valid__();
});

// Holds which rule is in error
observable.errorRule = ko.observable(null);

//manually set error state
observable.setError = function (error) {
observable.error(error);
Expand Down Expand Up @@ -1000,6 +1003,7 @@
//not valid, so format the error message and stick it in the 'error' variable
observable.error(exports.formatMessage(ctx.message || rule.message, ctx.params));
observable.__valid__(false);
observable.errorRule(rule);
return false;
} else {
return true;
Expand Down Expand Up @@ -1075,6 +1079,9 @@
}
}
//finally if we got this far, make the observable valid again!
if (observable.errorRule) {
observable.errorRule(null); // Clear the errored rule
}
observable.error(null);
observable.__valid__(true);
return true;
Expand Down