Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eccfc80 to
dd94d4d
Compare
dd94d4d to
0c2d43b
Compare
0c2d43b to
83abf64
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Triangle region works now!
rust/kcl-lib/std/sketch2.kcl
Outdated
| /// point to the intersection with the second segment, and turn at each | ||
| /// intersection using the `direction` until returning back to the first | ||
| /// segment. | ||
| @(impl = std_rust, experimental = true, feature_tree = true) |
There was a problem hiding this comment.
Can we change that to feature_tree = false? I don't think we need regions bubbled up?
There was a problem hiding this comment.
I changed it. But just FYI, it does create an object in the engine, so functions like that typically display in the Feature Tree.
There was a problem hiding this comment.
Ok thanks, and yeah we might want to revisit later then
|
Got a conflict that popped up @jtran ICYMI |
Resolves #10152.
Depends on KittyCAD/modeling-api#1106.
To enable the Point2d case, the return value of a sketch block now has the
KclValue::Sketchstored insketch1.meta.sketch. If there are no segments, it won't be present.