Closest edge lookup can limit to a given body#1120
Open
adamchalmers wants to merge 4 commits intomainfrom
Open
Closest edge lookup can limit to a given body#1120adamchalmers wants to merge 4 commits intomainfrom
adamchalmers wants to merge 4 commits intomainfrom
Conversation
Users will almost always know the ID of the solid/surface whose edge they're looking for, so we should allow scoping the search to only edges in that body.
adamchalmers
force-pushed
the
achalmers/closest-point-edge-tweak
branch
from
83b0f0a to
bf13549
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
=======================================
Coverage ? 30.09%
=======================================
Files ? 34
Lines ? 1585
Branches ? 0
=======================================
Hits ? 477
Misses ? 1108
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users will almost always know the ID of the solid/surface whose edge they're looking for, so we should allow scoping the search to only edges in that body.