Skip to content

Bump actions/cache from 4 to 5 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessfraz merged 1 commit into from
Mar 2, 2026
Merged

Bump actions/cache from 4 to 5 #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/make-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
tags:
- v*
permissions:
contents: write

Check failure on line 6 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions 

make-release.yml:6: overly broad permissions: contents: write is overly broad at the workflow level
name: make-release
jobs:
makerelease:
Expand All @@ -13,7 +13,7 @@
name: make release
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4

Check warning on line 16 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked 

make-release.yml:16: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
- name: 'Authenticate to Google Cloud'
uses: 'google-github-actions/auth@v3.0.0'
with:
Expand Down Expand Up @@ -41,17 +41,17 @@

cargo install toml-cli
- name: Cache cargo registry
uses: actions/cache@v4
uses: actions/cache@v5

Check failure on line 44 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

make-release.yml:44: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: ~/.cargo/registry
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
- name: Cache cargo index
uses: actions/cache@v4
uses: actions/cache@v5

Check failure on line 49 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

make-release.yml:49: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: ~/.cargo/git
key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}
- name: Cache cargo build
uses: actions/cache@v4
uses: actions/cache@v5

Check failure on line 54 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

make-release.yml:54: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: target
key: ${{ runner.os }}-cargo-build-target-${{ hashFiles('**/Cargo.lock') }}
Expand All @@ -67,7 +67,7 @@
export VERSION=v$(toml get Cargo.toml package.version | jq -r .)
mkdir -p releases/$(basename $(pwd))
cp -r cross releases/$(basename $(pwd))/${VERSION}
cp cross/README.md cross/${{matrix.os}}-${{github.ref_name}}-README.md

Check failure on line 70 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:70: code injection via template expansion: may expand into attacker-controllable code
- name: 'upload binary files'
id: upload-files
uses: google-github-actions/upload-cloud-storage@v2.2.1
Expand All @@ -91,7 +91,7 @@
needs: [makerelease]
name: createrelease
steps:
- uses: actions/checkout@v4

Check warning on line 94 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked 

make-release.yml:94: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
- name: Install latest nightly
uses: dtolnay/rust-toolchain@stable
- uses: actions/download-artifact@v4
Expand All @@ -114,8 +114,8 @@
ls -la
echo 'These instructions are meant as an easy way to install. Note: you likely need to install `coreutils` in order to have the `sha256sum` command.' > release.md
echo "" >> release.md
cat macos-latest-${{github.ref_name}}-README.md \

Check failure on line 117 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:117: code injection via template expansion: may expand into attacker-controllable code
ubuntu-latest-${{github.ref_name}}-README.md \

Check failure on line 118 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:118: code injection via template expansion: may expand into attacker-controllable code
>> release.md
rm build/*-README.md
rm build/README.md
Expand Down
Loading