Downstream 1.4.344 by hapakj · Pull Request #123 · KhronosGroup/VulkanSC-Loader

hapakj · 2026-03-02T13:26:42Z

Vulkan-Loader-1.4.344.patch

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.9 to 4.31.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [jidicula/clang-format-action](https://github.com/jidicula/clang-format-action) from 4.15.0 to 4.16.0. - [Release notes](https://github.com/jidicula/clang-format-action/releases) - [Commits](jidicula/clang-format-action@v4.15.0...v4.16.0) --- updated-dependencies: - dependency-name: jidicula/clang-format-action dependency-version: 4.16.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.0 to 4.31.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Also introduce TESTING_VULKAN_DIR macro in test framework

This shows up with the Vulkan CTS test "dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic" and appears to be a regression from KhronosGroup/Vulkan-Loader@77ccbe4

OSS-Fuzz added an 'advanced' fuzzer which creates multiple files by parsing the fuzz input file into multiple separate files. To add the fuzz test we needed to recreate the same logic that enables creating files.

Layers without a valid 'type' field should be ignored, which wasn't occurring.

The path the operating system returns may not be normalized, so comparing it with a normalized path yields false positives.

Found that vkcts crash after "Get real path to layer & driver binaries : 77ccbe4" merged into vullan-loader. The root cause of crash is icd.so lib has been closed before DestroyInstance called in loader free path when icd instance has been created and oom in layer. eg. fpCreateInstance success but table->populate oom in wsi. TRY_LOG(fpCreateInstance(&modified_info, pAllocator, pInstance) , "Failed to create the instance"); TRY_LOG_CALL(table->populate(*pInstance, fpGetInstanceProcAddr, api_version)); So we need to defer close icd lib until DestroyInstance done. Fix case: dEQP-VK.api.device_init.create_instance_device_ intentional_alloc_fail.basic Signed-off-by: Ryan Zhang <ryan.zhang@nxp.com>

This shows up in the dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic Vulkan CTS test.

Makes sure all calls to realloc have their return value put into a new variable. That way we don't lose the pointer to the original allocation in case realloc returns NULL and we need to free the original allocation.

Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.2 to 4.31.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0499de3...fdbfb4d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Intel CET uses a shadow stack to protect against ROP attacks by terminating the process if a shadow stack violation is detected in a module that has marked itself as CET-compatible with the /CETCOMPAT linker flag (and the process itself has CET enabled).

Exception handling continuation metadata further hardens control flow by ensuring NtContinue() or RtlRestoreContext() cannot be exploited to redirect exception handling to a target that is not a valid exception handler.

Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v5.0.1...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.5 to 4.31.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@fdbfb4d...fe4161a) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

For an ICD without support for VK_KHR_surface the surface list pointer will be null. This change adds a check for VK_KHR_surface to avoid an abort when accessing the surface list.

On macOS, applications can bundle drivers with themselves. When they do this and also install the same driver to a global location, the loader will load 2 separate drivers which happen to be the same binary, causing the linker to emit warnings. The fix was to simply only load one driver if the app was bundled. Because there was only one macOS driver available, this worked. Now that both KosmicKrisp and LavaPipe are available, this workaround is no longer appropriate. If apps bundle multiple drivers, they would be unable to use more than 1.

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.6 to 4.31.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@fe4161a...cf1bb45) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v6...v6.0.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

The settings file supports multiple different kind of settings, layers, devices, and drivers, mixing and matching each kind. This didn't work when there was only a single boolean to determine if the settings are active. Adding a separate boolean for layers and devices in the settings allows for only running settings file logic when the relevant parts of the settings file are present, so that a settings file with only devices doesn't interfere with the layer enumeration and vice versa. Additionally, using booleans instead of just checking if the list of layer/device settings are non-empty allows the user to specify "no layers" and "no devices" on the system.

If multiple layers share the same name, the loader should remove them as the application cannot specify which of the duplicate layers should be loaded when vkCreateInstance is called. This mirrors the behavior of vkCreateInstance which removes duplicate layers before loading. By de-duplicating during vkEnumerateInstanceLayerProperties and vkEnumerateInstanceExtensionProperties, it prevents situations where the duplicate layers differed in available instance extensions and the extension would be reported as unavailable during vkCreateInstance because the layer chosen to load didn't have the extension.

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.10 to 4.32.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@cdefb33...b20883b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v6.0.1...v6.0.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

After fixing a compilation error where PFN_GetPhysicalDeviceProcAddr was defined multiple times, the vk_layer_dispatch_table.h header lacks the required include that provided PFN_GetPhysicalDeviceProcAddr.

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.32.0 to 4.32.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b20883b...6bc82e0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.32.1 to 4.32.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@6bc82e0...45cbd0c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

The loop will only be entered whe .size() returns 1. For all the other case, it'll be skipped as the i == 0 condition is false.

This commit switch from prepending newly loaded ICDs to the ICD list, to appending them. Both options are fine since the order VkPhysicalDevices appear is unspecified, but by using an append operation the VkPhysicalDevices are returned in the same order as the drivers are loaded. See KhronosGroup/Vulkan-Loader#1725

This reverts commit ec72bb4.

This reverts commit f0ecb5a.

Makes sure nullptr's are checked before dereferencing it to check if the magic value is correct.

Move off of broken clang-format action by implementing our own format check

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.32.2 to 4.32.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@45cbd0c...9e907b5) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

CLAassistant · 2026-03-02T13:26:59Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 7 committers have signed the CLA.

✅ MathiasMagnus
❌ ryanKkaiii
❌ cgutman
❌ peppsac
❌ osy
❌ y-novikov
❌ TomCoo
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dependabot bot and others added 30 commits October 27, 2025 14:09

build: Update to header 1.4.331

6f557a4

build: Update to header 1.4.332

d03e515

loader: Use VULKAN_DIR macro in pathes

c0c74b8

Also introduce TESTING_VULKAN_DIR macro in test framework

Fix memory leak

dc509c2

This shows up with the Vulkan CTS test "dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic" and appears to be a regression from KhronosGroup/Vulkan-Loader@77ccbe4

Add instance_create_advanced_fuzzer runner

8b1274b

OSS-Fuzz added an 'advanced' fuzzer which creates multiple files by parsing the fuzz input file into multiple separate files. To add the fuzz test we needed to recreate the same logic that enables creating files.

Stop layers with an invalid "type" field from being added

1629b3b

Layers without a valid 'type' field should be ignored, which wasn't occurring.

build: Update to header 1.4.333

9a8d188

Normalize library paths queried from the OS

5eb9050

The path the operating system returns may not be normalized, so comparing it with a normalized path yields false positives.

Clean up allocated string during OOM from path normalization

655909f

loader: Fix another memory leak with use of realloc

bc0a957

This shows up in the dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic Vulkan CTS test.

Make realloc usage consistent

208e174

Makes sure all calls to realloc have their return value put into a new variable. That way we don't lose the pointer to the original allocation in case realloc returns NULL and we need to free the original allocation.

build: Update to header 1.4.334

ce04129

docs: Document filtering env var usage

8b9687f

cmake: Enable EH metadata on 64-bit MSVC builds

5f6d4be

Exception handling continuation metadata further hardens control flow by ensuring NtContinue() or RtlRestoreContext() cannot be exploited to redirect exception handling to a target that is not a valid exception handler.

build: Update to header 1.4.335

052ac24

Fix assert in terminator_DestroySurfaceKHR

918e869

For an ICD without support for VK_KHR_surface the surface list pointer will be null. This change adds a check for VK_KHR_surface to avoid an abort when accessing the surface list.

build: Update to header 1.4.336

dcb50be

charles-lunarg and others added 20 commits January 16, 2026 16:36

build: Update to header 1.4.340

cde3913

build: Update to header 1.4.341

32fcb94

Add missing include in vk_layer_dispatch_table.h

11aa53e

After fixing a compilation error where PFN_GetPhysicalDeviceProcAddr was defined multiple times, the vk_layer_dispatch_table.h header lacks the required include that provided PFN_GetPhysicalDeviceProcAddr.

build: Update to header 1.4.342

075488c

build: Update to header 1.4.343

5ad4fe5

Fix the wrong extension being used for GGP

ab275e4

Warn if headers is newer than generated version

67a2323

Fix backward loop condition in tests

f0ecb5a

The loop will only be entered whe .size() returns 1. For all the other case, it'll be skipped as the i == 0 condition is false.

Revert "Store ICDs in the loading order"

770660a

This reverts commit ec72bb4.

Revert "Fix backward loop condition in tests"

a3d9775

This reverts commit f0ecb5a.

Check for nullptr in loader_unwrap_physical_device

09a024d

Makes sure nullptr's are checked before dereferencing it to check if the magic value is correct.

Fix clang-format github action

aa0cd7b

Move off of broken clang-format action by implementing our own format check

build: Update to header 1.4.344

bac4131

hapakj force-pushed the downstream-1.4.344 branch 2 times, most recently from d5d6a05 to 1365af5 Compare March 2, 2026 13:59

build: Downstream Vulkan-Loader 1.4.344

144ef45

hapakj force-pushed the downstream-1.4.344 branch 2 times, most recently from 87f2027 to 9572305 Compare March 3, 2026 11:25

loader: add workaround for TestOnlyDriverEnvVarInFolder test on linux

7ce86b2

hapakj force-pushed the downstream-1.4.344 branch from 9572305 to 7ce86b2 Compare March 3, 2026 12:00

aqnuep merged commit 7ce86b2 into sc_main Mar 6, 2026
57 of 58 checks passed

aqnuep deleted the downstream-1.4.344 branch March 6, 2026 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downstream 1.4.344#123

Downstream 1.4.344#123
aqnuep merged 70 commits intosc_mainfrom
downstream-1.4.344

hapakj commented Mar 2, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

hapakj commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

hapakj commented Mar 2, 2026 •

edited

Loading

CLAassistant commented Mar 2, 2026 •

edited

Loading