layers: Add YCbCr2Plane VUs #11369

arno-lunarg · 2026-01-05T17:14:38Z

closes #11327

ci-tester-lunarg · 2026-01-05T17:14:42Z

CI Vulkan-ValidationLayers build queued with queue ID 615024.

ci-tester-lunarg · 2026-01-05T17:15:01Z

CI Vulkan-ValidationLayers build # 22030 running.

ci-tester-lunarg · 2026-01-05T17:17:33Z

CI Vulkan-ValidationLayers build queued with queue ID 615038.

ci-tester-lunarg · 2026-01-05T17:18:59Z

CI Vulkan-ValidationLayers build queued with queue ID 615051.

ci-tester-lunarg · 2026-01-05T17:20:02Z

CI Vulkan-ValidationLayers build # 22032 running.

arno-lunarg · 2026-01-05T17:22:51Z

layers/stateless/sl_instance_device.cpp

+        error = true;
+    }
+
+    // #ARNO_TODO what if vk_khr_get_physical_device_properties2 is not enabled?


Still need to figure this out, @spencer-lunarg do you know?

You shouldn't be calling here, you will need to use special_supported.h like we do for has_maintenance9

I don't see why this approach is better (having to add new state)? We already track the info I am interested in

We already track the info

then why are we calling DispatchGetPhysicalDeviceFeatures2 every vkGetPhysicalDeviceFormatProperties2?

having to add new state

I mean it is a single boolean to the Instance level tracking and we already have a dedicated class for this type of "check if supported" ... not sure why we suddenly need now some places that use SpecialSupported and some that are calling their own dispatch to check, want a single way to do things above all

aaaah we were not talking about the same thing, I was talking about the IsExtEnabled(extensions.vk_khr_get_physical_device_properties2) call, not how we get ycbcr_formats_features.ycbcr2plane444Formats. I get what you mean now, will do as you suggested!

Ah I don't think using special_supported.h is possible, this struct is stored in some VkDevice state, in this function I have only access to a VkPhysicalDevice...

spencer-lunarg · 2026-01-05T18:34:08Z

layers/stateless/sl_instance_device.cpp

+    VkFormatProperties2 format_props_2 = vku::InitStructHelper();
+    format_props_2.formatProperties = *pFormatProperties;
+
+    skip |= manual_PreCallValidateGetPhysicalDeviceFormatProperties2(physicalDevice, format, &format_props_2, context);


we only call manual_ from the generated code... can you make a common Instance::ValidateGetPhysicalDeviceFormatProperties2() to have them both call

ci-tester-lunarg · 2026-01-05T19:09:58Z

CI Vulkan-ValidationLayers build # 22032 failed.

ci-tester-lunarg · 2026-01-06T09:58:48Z

CI Vulkan-ValidationLayers build queued with queue ID 615470.

ci-tester-lunarg · 2026-01-06T10:00:01Z

CI Vulkan-ValidationLayers build # 22037 running.

ci-tester-lunarg · 2026-01-06T10:01:04Z

CI Vulkan-ValidationLayers build queued with queue ID 615484.

ci-tester-lunarg · 2026-01-06T10:05:01Z

CI Vulkan-ValidationLayers build # 22038 running.

ci-tester-lunarg · 2026-01-06T10:52:30Z

CI Vulkan-ValidationLayers build # 22038 failed.

ci-tester-lunarg · 2026-01-06T11:08:20Z

CI Vulkan-ValidationLayers build queued with queue ID 615586.

ci-tester-lunarg · 2026-01-06T11:10:01Z

CI Vulkan-ValidationLayers build # 22041 running.

ci-tester-lunarg · 2026-01-06T13:10:01Z

CI Vulkan-ValidationLayers build # 22041 aborted.

ci-tester-lunarg · 2026-01-06T17:06:46Z

CI Vulkan-ValidationLayers build queued with queue ID 616029.

ci-tester-lunarg · 2026-01-06T17:09:55Z

CI Vulkan-ValidationLayers build # 22054 running.

ci-tester-lunarg · 2026-01-06T17:29:33Z

CI Vulkan-ValidationLayers build # 22054 failed.

ci-tester-lunarg · 2026-01-08T11:26:00Z

CI Vulkan-ValidationLayers build queued with queue ID 617615.

ci-tester-lunarg · 2026-01-08T11:30:01Z

CI Vulkan-ValidationLayers build # 22076 running.

ci-tester-lunarg · 2026-01-08T13:30:01Z

CI Vulkan-ValidationLayers build # 22076 aborted.

ci-tester-lunarg · 2026-01-09T12:27:03Z

CI Vulkan-ValidationLayers build # 22102 passed.

spencer-lunarg · 2026-01-09T15:39:18Z

layers/stateless/sl_instance_device.cpp

+        VkPhysicalDeviceFeatures2 features_2 = vku::InitStructHelper();
+        VkPhysicalDeviceYcbcr2Plane444FormatsFeaturesEXT ycbcr_formats_features = vku::InitStructHelper();
+        features_2.pNext = &ycbcr_formats_features;
+        DispatchGetPhysicalDeviceFeatures2(physicalDevice, &features_2);


We don't need this, we have special_supported.h for a reason, we don't need to reimplement this query logic for every spot

actually, wait, we don't need this... ycbcr2plane444Formats is required to be supported if the vk_ext_ycbcr_2plane_444_formats is supported... something is wrong here.. this is more complex then I think we need

if exposed_extensions.vk_ext_ycbcr_2plane_444_formats is false that is the same as ycbcr2plane444Formats not being supported

if (IsValueIn(format, {VK_FORMAT_G8_B8R8_2PLANE_444_UNORM, VK_FORMAT_G10X6_B10X6R10X6_2PLANE_444_UNORM_3PACK16, VK_FORMAT_G12X4_B12X4R12X4_2PLANE_444_UNORM_3PACK16, VK_FORMAT_G16_B16R16_2PLANE_444_UNORM})) { const auto &exposed_extensions = physical_device_extensions.at(physicalDevice); if (api_version < VK_API_VERSION_1_3 && !exposed_extensions.vk_khr_maintenance5 && !exposed_extensions.vk_ext_ycbcr_2plane_444_formats) { const char *vuid = context.error_obj.location.function == Func::vkGetPhysicalDeviceFormatProperties ? "VUID-vkGetPhysicalDeviceFormatProperties-None-12272" : "VUID-vkGetPhysicalDeviceFormatProperties2-None-12273"; skip |= LogError(vuid, physicalDevice, context.error_obj.location.dot(Field::format), "is %s.", string_VkFormat(format)); } }

should be enough

ci-tester-lunarg · 2026-01-12T09:10:33Z

CI Vulkan-ValidationLayers build queued with queue ID 620181.

ci-tester-lunarg · 2026-01-12T09:15:01Z

CI Vulkan-ValidationLayers build # 22125 running.

ci-tester-lunarg · 2026-01-12T10:30:43Z

CI Vulkan-ValidationLayers build # 22125 failed.

ci-tester-lunarg · 2026-01-12T10:52:46Z

CI Vulkan-ValidationLayers build queued with queue ID 620231.

ci-tester-lunarg · 2026-01-12T10:55:01Z

CI Vulkan-ValidationLayers build # 22127 running.

ci-tester-lunarg · 2026-01-12T12:12:54Z

CI Vulkan-ValidationLayers build # 22127 failed.

ci-tester-lunarg · 2026-01-12T15:44:16Z

CI Vulkan-ValidationLayers build queued with queue ID 620431.

ci-tester-lunarg · 2026-01-12T15:45:01Z

CI Vulkan-ValidationLayers build # 22128 running.

ci-tester-lunarg · 2026-01-12T16:31:33Z

CI Vulkan-ValidationLayers build # 22128 failed.

ci-tester-lunarg · 2026-01-12T17:11:49Z

CI Vulkan-ValidationLayers build queued with queue ID 620587.

ci-tester-lunarg · 2026-01-12T17:12:07Z

CI Vulkan-ValidationLayers build # 22134 running.

ci-tester-lunarg · 2026-01-12T19:27:28Z

CI Vulkan-ValidationLayers build # 22134 failed.

ci-tester-lunarg · 2026-01-13T10:46:32Z

CI Vulkan-ValidationLayers build queued with queue ID 621296.

ci-tester-lunarg · 2026-01-13T10:47:30Z

CI Vulkan-ValidationLayers build # 22143 running.

ci-tester-lunarg · 2026-01-13T10:52:54Z

CI Vulkan-ValidationLayers build # 22143 failed.

ci-tester-lunarg · 2026-01-14T16:15:49Z

CI Vulkan-ValidationLayers build queued with queue ID 622585.

ci-tester-lunarg · 2026-01-14T16:20:01Z

CI Vulkan-ValidationLayers build # 22155 running.

ci-tester-lunarg · 2026-01-14T17:00:56Z

CI Vulkan-ValidationLayers build # 22155 failed.

ci-tester-lunarg · 2026-01-15T11:29:40Z

CI Vulkan-ValidationLayers build queued with queue ID 623223.

arno-lunarg requested a review from a team as a code owner January 5, 2026 17:14

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 2c8421c to 5f825e6 Compare January 5, 2026 17:17

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 5f825e6 to ab9ed36 Compare January 5, 2026 17:18

arno-lunarg commented Jan 5, 2026

View reviewed changes

spencer-lunarg reviewed Jan 5, 2026

View reviewed changes

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from ab9ed36 to 783e2a8 Compare January 6, 2026 09:58

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 783e2a8 to 53df244 Compare January 6, 2026 10:01

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 53df244 to c3ef19e Compare January 6, 2026 11:08

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from c3ef19e to 0e66231 Compare January 8, 2026 11:25

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 0e66231 to 468d9ee Compare January 8, 2026 16:51

spencer-lunarg reviewed Jan 9, 2026

View reviewed changes

layers: Add YCbCr2Plane VUs

9c47379

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 11a1b5f to 9c47379 Compare January 12, 2026 09:10

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 604ddbb to b67f0ca Compare January 12, 2026 15:44

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from b67f0ca to cf4c0ae Compare January 12, 2026 17:11

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from cf4c0ae to 49f7176 Compare January 13, 2026 10:46

debug: Debug

6f1bfb5

arno-lunarg force-pushed the arno-layers-i-am-the-new-ycbcr-expert-now branch from 49f7176 to 6f1bfb5 Compare January 14, 2026 16:15

layers: Fix used api version

49a5e89

arno-lunarg closed this Jan 15, 2026

layers: Add YCbCr2Plane VUs #11369

layers: Add YCbCr2Plane VUs #11369

Conversation

arno-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arno-lunarg Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ci-tester-lunarg commented Jan 5, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 6, 2026

Uh oh!

ci-tester-lunarg commented Jan 8, 2026

Uh oh!

ci-tester-lunarg commented Jan 8, 2026

Uh oh!

ci-tester-lunarg commented Jan 8, 2026

Uh oh!

ci-tester-lunarg commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ci-tester-lunarg commented Jan 12, 2026

Uh oh!

ci-tester-lunarg commented Jan 12, 2026

Uh oh!

ci-tester-lunarg commented Jan 12, 2026

Uh oh!

ci-tester-lunarg commented Jan 12, 2026

Uh oh!

ci-tester-lunarg commented Jan 12, 2026

arno-lunarg Jan 7, 2026 •

edited

Loading