vulkaninfo: Fix running under RenderDoc #1185
Conversation
|
Author werman not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author werman not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Good suggestion, but can we leave the VkDevice object at the parent scope so that if an exception is thrown, the AppGpu can clean up the created VkDevice handle.
This means that the commit is adding vkDestroyDevice(dev, nullptr); dev = VK_NULL_HANDLE; at the end of the constructor, then in the destructor only destroying the device if the handle isn't NULL.
RenderDoc allows only one simultaneously existing logical device, and vulkaninfo doesn't have a real need to keep them simultaneously alive. Running vulkaninfo under RenderDoc is useful to get a Vulkan profile that will represent the RenderDoc capabilities on the current GPU, which can be useful to, e.g., make a gfxreconstruct trace that will be later capturable by RenderDoc. Signed-off-by: Danylo Piliaiev <[email protected]>
werman
force-pushed
the
fix/vulkaninfo-with-renderdoc
branch
from
eb6cd49 to
b6abaf7
Compare
Makes sense, done. |
|
CI Vulkan-Tools build queued with queue ID 596382. |
|
CI Vulkan-Tools build # 1880 running. |
|
CI Vulkan-Tools build # 1880 passed. |
4 participants
RenderDoc allows only one simultaneously existing logical device, and vulkaninfo doesn't have a real need to keep them simultaneously alive.
Running vulkaninfo under RenderDoc is useful to get a Vulkan profile that will represent the RenderDoc capabilities on the current GPU, which can be useful to, e.g., make a gfxreconstruct trace that will be later capturable by RenderDoc.
With the change
ENABLE_VULKAN_RENDERDOC_CAPTURE=1 vulkaninfocrashes with: