cube: Correctly apply sRGB OETF/EOTF #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build. |
HildarTheDorf
commented
Jan 22, 2025
| @@ -1,41 +1,84 @@ | |||
| // 7.9.2888 | |||
| 0x07230203,0x00010000,0x00080007,0x00000030,0x00000000,0x00020011,0x00000001,0x0006000b, | |||
| // 1115.1.0 | |||
Contributor
Author
There was a problem hiding this comment.
Wow that's a lot of versions of glslang
Contributor
There was a problem hiding this comment.
I am unsure when the checked in code was compiled, because Vulkan-Tools used to compile glslang, then it went to just downloading the binary, to the current checked in state.
charles-lunarg
approved these changes
Jan 22, 2025
|
CI Vulkan-Tools build queued with queue ID 352491. |
|
CI Vulkan-Tools build # 1605 running. |
|
CI Vulkan-Tools build # 1605 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vkcube is incorrectly treating srgb texture values as linear, then writing linear values to a COLORSPACE_SRGB_NONLINEAR swapchain image without an _SRGB format or manual correction.
VK_FORMAT_R8G8B8A8_SRGB as a sampled image format is required to be supported, so changing the input texture is fine.
SRGB formats for swapchain are required if the equivalent UNORM is supported (and vice-versa). However it is possible for unextended vulkan 1.4 to only support 1010102 or 565 etc. formats.
This results in a slight overall change to the lighting of the cube. But it is more correct for those using vkcube's code as an example.