Remove duplicates from vkEnumerateInstanceLayerProperties #1844
+86
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple layers share the same name, the loader should remove them as the application cannot specify which of the duplicate layers should be loaded when vkCreateInstance is called. This mirrors the behavior of vkCreateInstance which removes duplicate layers before loading. By de-duplicating during vkEnumerateInstanceLayerProperties and vkEnumerateInstanceExtensionProperties, it prevents situations where the duplicate layers differed in available instance extensions and the extension would be reported as unavailable during vkCreateInstance because the layer chosen to load didn't have the extension.
|
CI Vulkan-Loader build queued with queue ID 624921. |
spencer-lunarg
approved these changes
Jan 16, 2026
Contributor
spencer-lunarg
left a comment
spencer-lunarg
left a comment
There was a problem hiding this comment.
👍 to making Mike happy
|
CI Vulkan-Loader build # 3374 running. |
|
CI Vulkan-Loader build # 3374 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple layers share the same name, the loader should remove them as the application cannot specify which of the duplicate layers should be loaded when vkCreateInstance is called. This mirrors the behavior of vkCreateInstance which removes duplicate layers before loading. By de-duplicating during vkEnumerateInstanceLayerProperties and vkEnumerateInstanceExtensionProperties, it prevents situations where the duplicate layers differed in available instance extensions and the extension would be reported as unavailable during vkCreateInstance because the layer chosen to load didn't have the extension.