Generate asm directly when cross-compiling #1839
Conversation
`-save-temps=obj` breaks on availability checks when compiling for visionOS. There is no need to compile the executable when cross-compiling so instead we pass in '-S' to just generate the assembly.
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
I will need more time to review this properly - cross compilation isn't tested regularly, so there isn't a test environment setup (as in, I get to pull out my raspberry pi 😄 )
On first review, this looks like a good change. From what I recall, -save-temps=obj was used to enable the parse_asm_values.py script, but if -S works and doesn't differ between GNU, clang & AppleClang then I'm all for it.
|
CI Vulkan-Loader build queued with queue ID 616179. |
|
CI Vulkan-Loader build # 3359 running. |
|
CI Vulkan-Loader build # 3359 passed. |
4 participants
-save-temps=objbreaks on availability checks when compiling for visionOS. There is no need to compile the executable when cross-compiling so instead we pass in '-S' to just generate the assembly.