video encode: Fix tests for implementations with detection of insufficient bitstream buffer range #487
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests dEQP-VK.video.capabilities.*_encode_capabilities_query failed if the implementation supports VK_VIDEO_ENCODE_CAPABILITY_INSUFFICIENT_BITSTREAM_BUFFER_RANGE_DETECTION_BIT_KHR. This adds this as a valid flag. Affects: dEQP-VK.video.capabilities.h264_encode_capabilities_query dEQP-VK.video.capabilities.h265_encode_capabilities_query
According spec: "dstBufferRange is the maximum bitstream size in bytes that can be written to dstBuffer, starting from dstBufferOffset." This member was set to 0 and so no bitstream could be written. Affects: dEQP-VK.video.encode.*
|
|
Contributor
|
Could you please sign the CLA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows implementation to report
VK_VIDEO_ENCODE_CAPABILITY_INSUFFICIENT_BITSTREAM_BUFFER_RANGE_DETECTION_BIT_KHRwithout causing a failed test dEQP-VK.video.capabilities.*_encode_capabilities_query.Further this change sets
dstBufferRangeinVkVideoEncodeInfoKHRto valid values (instead of 0) so that implementations supporting insufficient bitstream buffer range detection do not report an error on video encode.