Blazor rewrite #383
Blazor rewrite #383
Conversation
JosefDvorak
left a comment
JosefDvorak
left a comment
There was a problem hiding this comment.
Most issues are trivial or cosmetic. However, there are a few changes to structure that should be made, to keep consistency with other Kentico repos.
| @@ -0,0 +1,2 @@ | |||
| UPDATE CMS_WebFarmServer SET ServerDisplayName = ServerDisplayName + N'.disabled', ServerEnabled = 0 | |||
There was a problem hiding this comment.
If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.
| @@ -0,0 +1,2 @@ | |||
| UPDATE Staging_Server SET ServerDisplayName = ServerDisplayName + N'.disabled', ServerEnabled = 0 | |||
There was a problem hiding this comment.
If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.
There was a problem hiding this comment.
If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.
There was a problem hiding this comment.
Column ServerAuthenticationType was only added in Kentico Xperience 13 refresh, to enable OAuth SMTP server authentication. This makes this report incompatible with earlier version.
There was a problem hiding this comment.
Column ServerAuthenticationType was only added in Kentico Xperience 13 refresh, to enable OAuth SMTP server authentication. This makes this report incompatible with earlier version.
| ############################################################################### | ||
| # Set default behavior to automatically normalize line endings. | ||
| ############################################################################### | ||
| * text=auto |
There was a problem hiding this comment.
Normalizing line encoding can be useful to avoid issues when merging. I'll accept this change for now, but if we run into issues in future, we may need to re-introduce this configuration.
There was a problem hiding this comment.
The license file should not be arbitrarily re-written.
|
Merged as part of #384 |
2 participants
Motivation
Checklist