Skip to content

Conversation

@sarth-akvaish
Copy link
Contributor

Refactored the IField interface by separating core, type-related, and choice-related properties into dedicated interfaces and composing them back together. This enables adding choice metadata without breaking existing code, improves interface clarity, and keeps runtime behavior unchanged.

Issue : #2729

@sarth-akvaish sarth-akvaish force-pushed the datamapper/model-update#2729 branch from b43e4dd to a12ee29 Compare December 26, 2025 17:05
Copy link
Member

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to remove those TSDoc comments?

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.46%. Comparing base (15b724b) to head (a12ee29).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/models/datamapper/document.ts 10.00% 27 Missing ⚠️
...src/services/json-schema-document-model.service.ts 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
- Coverage   86.57%   86.46%   -0.11%     
==========================================
  Files         519      519              
  Lines       17507    17558      +51     
  Branches     3789     3927     +138     
==========================================
+ Hits        15156    15182      +26     
- Misses       2347     2372      +25     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarth-akvaish
Copy link
Contributor Author

sarth-akvaish commented Jan 5, 2026

Is there any reason to remove those TSDoc comments?

No, will fix it and update the PR with the patch coverage.

Also, looks like we have to add new tests for document.ts file as adopt method behaviour is changed.

What's your thoughts on this @igarashitm ?

@igarashitm
Copy link
Member

That's a good idea, now that adapt() is no longer a trivial one, we can add document.test.ts and add some tests for it.

@sarth-akvaish sarth-akvaish force-pushed the datamapper/model-update#2729 branch from 0c46584 to e400631 Compare January 12, 2026 16:37
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants