fix: fix issues with API Gateway Access #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes API Gateway access issues in the staging environment by ensuring proper dependency management for Lambda permissions and temporarily disabling CloudFront access restrictions.
Key Changes:
- Added Lambda permission dependencies to API Gateway deployment to prevent race conditions
- Commented out CloudFront access restriction policy
- Updated checkov pre-commit hook version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aws/non-prod-infra/staging/apigateway_core.tf | Added Lambda permission dependencies to deployment and commented out CloudFront restriction policy |
| .pre-commit-config.yaml | Updated checkov version from 3.2.484 to 3.2.487 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| # # Restricts API Gateway access to CloudFront in staging | ||
| # resource "aws_api_gateway_rest_api_policy" "restrict_to_cloudfront" { | ||
| # count = var.env == "staging" || var.env == "staging" ? 1 : 0 |
There was a problem hiding this comment.
The condition var.env == \"staging\" || var.env == \"staging\" is redundant—it checks the same condition twice. This should likely be var.env == \"staging\" or compare against a different environment value.
Suggested change
| # count = var.env == "staging" || var.env == "staging" ? 1 : 0 | |
| # count = var.env == "staging" ? 1 : 0 |
kuziel-radziwonm
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.