feat: Added Lifecycle to prevent API gateway Lambda Invoke permissions #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds lifecycle configurations to API Gateway Lambda invoke permissions to prevent Terraform drift during deployments. The changes enhance infrastructure stability by ignoring changes to function names and qualifiers that are managed through CI/CD pipelines.
- Adds lifecycle blocks to AWS Lambda permission resources for API Gateway integration
- Implements ignore_changes for function_name and qualifier attributes on Lambda permissions
- Fixes a duplicate condition in production environment API Gateway policy
Reviewed Changes
Copilot reviewed 94 out of 95 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aws/prod-infra/prod/apigateway_kfd_services.tf | Adds lifecycle ignore_changes to Lambda permissions for KFD services |
| aws/prod-infra/prod/apigateway_core.tf | Adds lifecycle configurations and fixes duplicate prod condition |
| aws/non-prod-infra/staging/apigateway_kfd_services.tf | Adds lifecycle ignore_changes to Lambda permissions for KFD services |
| aws/non-prod-infra/staging/apigateway_core.tf | Adds lifecycle ignore_changes to Lambda permissions and stage deployment |
| aws/non-prod-infra/dev/apigateway_kfd_services.tf | Adds lifecycle ignore_changes to Lambda permissions including regional APIs |
| aws/non-prod-infra/dev/apigateway_core.tf | Adds lifecycle ignore_changes to Lambda permissions and stage deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| resource "aws_api_gateway_rest_api_policy" "restrict_to_cloudfront" { | ||
| count = var.env == "prod" || var.env == "prod" ? 1 : 0 | ||
| count = var.env == "prod" ? 1 : 0 |
There was a problem hiding this comment.
Fixed redundant condition. The original code checked 'var.env == "prod" || var.env == "prod"' which was logically equivalent to just 'var.env == "prod"'.
shaunganley
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.