fix: Updated API gateway Lambda Invoke Permissions #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates API Gateway Lambda invoke permissions to use function name with alias syntax instead of alias ARN across multiple environments. The change ensures proper permission granting for Lambda alias invocation from API Gateway.
- Updates AWS Lambda permission configurations across prod, staging, dev, and backup environments
- Modifies function_name parameter from lambda_alias_arn to function_name:alias format
- Removes comment clutter from Terraform files and streamlines CI/CD workflow
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aws/prod-infra/prod/apigateway_kfd_services.tf | Updates Lambda permissions to use function name with alias format |
| aws/prod-infra/prod/apigateway_core.tf | Updates core Lambda permissions and removes redundant comments |
| aws/non-prod-infra/staging/apigateway_kfd_services.tf | Updates staging KFD service Lambda permissions with explanatory comments |
| aws/non-prod-infra/staging/apigateway_core.tf | Updates staging core Lambda permissions |
| aws/non-prod-infra/dev/apigateway_kfd_services.tf | Updates dev environment Lambda permissions for both standard and regional APIs |
| aws/non-prod-infra/dev/apigateway_core.tf | Updates dev core Lambda permissions |
| aws/backup/staging/variables.tf | Adds kfd_api_lambda_alias variable definition |
| aws/backup/staging/apigateway_kfd_services.tf | Updates backup staging Lambda permissions |
| aws/backup/dev/variables.tf | Adds kfd_api_lambda_alias variable definition |
| aws/backup/dev/apigateway_kfd_services.tf | Updates backup dev Lambda permissions |
| .github/workflows/nonprod-deploy-specific-env.yaml | Simplifies workflow by removing artifact upload/download steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # Restricts API Gateway access to CloudFront in production and prod | ||
| resource "aws_api_gateway_rest_api_policy" "restrict_to_cloudfront" { | ||
| count = var.env == "prod" || var.env == "prod" ? 1 : 0 |
There was a problem hiding this comment.
Redundant condition in the count parameter. The expression 'var.env == "prod" || var.env == "prod"' should be simplified to 'var.env == "prod"' as both conditions are identical.
Suggested change
| count = var.env == "prod" || var.env == "prod" ? 1 : 0 | |
| count = var.env == "prod" ? 1 : 0 |
cptiv2020
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.