Skip to content

Conversation

@erastusndico
Copy link
Contributor

No description provided.

@erastusndico erastusndico requested a review from a team as a code owner September 30, 2025 09:35
Copilot AI review requested due to automatic review settings September 30, 2025 09:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where Terraform plan output was not being properly passed to the apply stage by implementing artifact upload/download between workflow jobs. The changes ensure that the plan files generated in the plan job are available to the apply job, which is necessary for proper Terraform workflow execution.

  • Added plan artifact upload steps after plan execution
  • Replaced plan re-execution in apply jobs with plan artifact download
  • Removed redundant Python setup in nonprod workflow

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/prod-deployment.yaml Added plan upload/download between plan and apply jobs
.github/workflows/prod-deploy-specific-env.yaml Added plan upload/download between plan and apply jobs
.github/workflows/prod-deploy-roles.yaml Added plan upload/download between plan and apply jobs
.github/workflows/nonprod-deployment.yaml Added plan upload/download and removed redundant Python setup
.github/workflows/nonprod-deploy-specific-env.yaml Added plan upload/download between plan and apply jobs
.github/workflows/nonprod-deploy-roles.yaml Added plan upload/download between plan and apply jobs
Comments suppressed due to low confidence (1)

.github/workflows/nonprod-deployment.yaml:60

  • The step name says 'Run Terraform plan' but the command executes 'make apply'. This was likely the original bug being fixed - the step should be removed since the plan is now downloaded from artifacts.
      - name: Run Terraform plan

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@erastusndico erastusndico merged commit 9ee5144 into main Sep 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants