Skip to content

fix: correctly export policy in genesis #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbreithecker merged 1 commit into from
Aug 22, 2025
Merged

fix: correctly export policy in genesis #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ An '!' indicates a state machine breaking change.

### Improvements

- ! [#266](https://github.com/KYVENetwork/chain/pull/266) Improve storage cost payout.
- ! (`x/bundles`) [#266](https://github.com/KYVENetwork/chain/pull/266) Improve storage cost payout.

### Bug Fixes

- (`x/multi_coin_rewards`) [#269](https://github.com/KYVENetwork/chain/pull/269) Correctly export policy in genesis.

## [v2.1.0](https://github.com/KYVENetwork/chain/releases/tag/v2.1.0) - 2025-04-29

Expand Down
5 changes: 5 additions & 0 deletions x/multi_coin_rewards/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ func InitGenesis(ctx sdk.Context, k keeper.Keeper, genState types.GenesisState)
}

k.SetQueueState(ctx, types.QUEUE_IDENTIFIER_MULTI_COIN_REWARDS, genState.QueueStatePendingRewards)

err := k.MultiCoinDistributionPolicy.Set(ctx, *genState.MultiCoinDistributionPolicy)
if err != nil {
panic(err)
}
}

// ExportGenesis returns the capability module's exported genesis.
Expand Down
20 changes: 12 additions & 8 deletions x/multi_coin_rewards/keeper/msg_server_distribution_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ var _ = Describe("msg_server_distribution_policy_test.go", Ordered, func() {

// ASSERT
Expect(err.Error()).To(Equal("duplicate entry for denom acoin"))
_, err = s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).NotTo(BeNil())
policy, err := s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).To(BeNil())
Expect(policy.Entries).To(HaveLen(0))
})

It("Invalid Policy: Duplicate pool entries for same denom", func() {
Expand Down Expand Up @@ -167,8 +168,9 @@ var _ = Describe("msg_server_distribution_policy_test.go", Ordered, func() {

// ASSERT
Expect(err.Error()).To(Equal("duplicate distribution weight for pool id 0"))
_, err = s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).NotTo(BeNil())
policy, err := s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).To(BeNil())
Expect(policy.Entries).To(HaveLen(0))
})

It("Invalid Policy: Negative weights", func() {
Expand All @@ -194,8 +196,9 @@ var _ = Describe("msg_server_distribution_policy_test.go", Ordered, func() {

// ASSERT
Expect(err.Error()).To(Equal("invalid weight for pool id 0"))
_, err = s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).NotTo(BeNil())
policy, err := s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).To(BeNil())
Expect(policy.Entries).To(HaveLen(0))
})

It("Invalid Policy: Zero weights", func() {
Expand All @@ -221,7 +224,8 @@ var _ = Describe("msg_server_distribution_policy_test.go", Ordered, func() {

// ASSERT
Expect(err.Error()).To(Equal("invalid weight for pool id 0"))
_, err = s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).NotTo(BeNil())
policy, err := s.App().MultiCoinRewardsKeeper.MultiCoinDistributionPolicy.Get(s.Ctx())
Expect(err).To(BeNil())
Expect(policy.Entries).To(HaveLen(0))
})
})