Fix UB due to invalid int->enum cast #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
force-pushed
the
wip/dfaure/fix-ub-enum-cast
branch
from
68b16b2 to
35d340f
Compare
dfaure-kdab
force-pushed
the
wip/dfaure/fix-ub-enum-cast
branch
3 times, most recently
from
5a7f02c to
c84e04d
Compare
Use std::optional instead, to represent the case where no constraint is set. Detected by UBSAN: KDReportsAbstractTableElement.cpp:126:13: runtime error: load of value 2, which is not a valid value for type 'Unit'
dfaure-kdab
force-pushed
the
wip/dfaure/fix-ub-enum-cast
branch
from
042193e to
396c675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::optional instead, to represent the case where no constraint is set.
Detected by UBSAN:
KDReportsAbstractTableElement.cpp:126:13: runtime error: load of value 2, which is not a valid value for type 'Unit'