Open
Conversation
Override the standard `mapreduce` machinery to promote accumulator type. This avoid calling the function twice, which can be confusing.
ac9937d to
6877ebf
Compare
Member
Author
|
The new commit implements a simpler approach which is fast for concrete eltypes but super slow for complex type unions as the compiler doesn't infer an element type more precise than julia> @btime mean(x);
68.529 ms (4 allocations: 64 bytes)
julia> @btime mean(y);
550.489 ms (0 allocations: 0 bytes)
julia> @btime mean(z);
2.752 s (25300984 allocations: 386.06 MiB) |
Contributor
|
It looks like you're reimplementing undocumented |
Member
Author
|
Yes, but given that Statistics is an stdlib any breakage would be noticed in Julia even before merging it. I'm more concerned about performance issues introduced by the PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override the standard
mapreducemachinery to promote accumulator type.This avoid calling the function twice, which can be confusing.
Fixes #49 but with a more general solution than #80.
Cc: @stevengj @kagalenko-m-b
Unfortunately, performance drops for a
Float64vector:This is simply due to
sumbeing slower wheninitis provided as it callsmapfoldlunder the hood in that case: