Open
Conversation
Member
Author
|
KLU.jl, AMD.jl, and the various "almost-complete" wrappers I have of the other SuiteSparse libraries should be updated to do this correctly. Could be a candidate for backport since this does fix incorrect GC statistics as a byproduct. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 84.19% 84.33% +0.13%
==========================================
Files 12 13 +1
Lines 9313 9311 -2
==========================================
+ Hits 7841 7852 +11
+ Misses 1472 1459 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This is ready, although I have no idea how backporting works |
Member
|
Feels pretty straightforward to me. For backporting, just tag with the right label. @dkarrasch has been helping prepare the backport PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a unified initialization function for all SuiteSparse libraries (both in the stdlib and elsewhere like KLU). This remains lazily initialized. Should address #671.
I wonder whether this should be truly
publicbut KLU, AMD, and ParU, SPEX will rely on this to function correctly so probably should be.Also bumps wrapper generation.
@gbaraldi not sure how to test this with your PR but tests on MinFEM.jl seem to pass locally for me.