Skip to content

Comments

Unify initialization of SuiteSparse libraries#677

Open
rayegun wants to merge 2 commits intomainfrom
unify_config
Open

Unify initialization of SuiteSparse libraries#677
rayegun wants to merge 2 commits intomainfrom
unify_config

Conversation

@rayegun
Copy link
Member

@rayegun rayegun commented Feb 16, 2026

Create a unified initialization function for all SuiteSparse libraries (both in the stdlib and elsewhere like KLU). This remains lazily initialized. Should address #671.

I wonder whether this should be truly public but KLU, AMD, and ParU, SPEX will rely on this to function correctly so probably should be.

Also bumps wrapper generation.

@gbaraldi not sure how to test this with your PR but tests on MinFEM.jl seem to pass locally for me.

@rayegun
Copy link
Member Author

rayegun commented Feb 16, 2026

KLU.jl, AMD.jl, and the various "almost-complete" wrappers I have of the other SuiteSparse libraries should be updated to do this correctly.

Could be a candidate for backport since this does fix incorrect GC statistics as a byproduct.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.33%. Comparing base (4500d86) to head (a54a3ed).

Files with missing lines Patch % Lines
src/solvers/LibSuiteSparse.jl 60.00% 10 Missing ⚠️
src/solvers/wrappers.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   84.19%   84.33%   +0.13%     
==========================================
  Files          12       13       +1     
  Lines        9313     9311       -2     
==========================================
+ Hits         7841     7852      +11     
+ Misses       1472     1459      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah added backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Feb 18, 2026
@rayegun rayegun requested a review from ViralBShah February 19, 2026 19:02
@rayegun
Copy link
Member Author

rayegun commented Feb 19, 2026

This is ready, although I have no idea how backporting works

@ViralBShah
Copy link
Member

Feels pretty straightforward to me. For backporting, just tag with the right label. @dkarrasch has been helping prepare the backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants