refactor: improve norm calculation for magnetic field vectors#30
Merged
refactor: improve norm calculation for magnetic field vectors#30
Conversation
Beforerr
force-pushed
the
push-kurznxpvrsxo
branch
from
e1b6d7d to
37f5f98
Compare
most of the changes aims to fix JET reporting issues - Replace LinearAlgebra.norm with custom _norm function using norm_sqr for better handling of vector quantities - Split Alfven_speed and Alfven_velocity implementations to handle scalar BField and vector BFields separately
Beforerr
force-pushed
the
push-kurznxpvrsxo
branch
from
37f5f98 to
3dd64cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the changes aims to fix JET reporting issues