Adding some more astro units#196
Merged
MilesCranmer merged 1 commit intoJuliaPhysics:mainfrom Jan 5, 2026
Merged
Conversation
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 21 21
Lines 1292 1292
=======================================
Hits 1281 1281
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Howdy, would you like to see anything different for this? Happy to make any changes! |
Contributor
Author
|
Gentle ping @MilesCranmer |
Contributor
Author
|
Happy new year! Just checking back in on if anything else is needed for this |
Member
|
@codex please review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
MilesCranmer
approved these changes
Jan 5, 2026
Member
MilesCranmer
left a comment
MilesCranmer
left a comment
There was a problem hiding this comment.
Looks good! Thanks and sorry for the delayed review.
Contributor
Author
|
No worries, appreciate you taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #25
Added a few cgs and other units that show up in astro fairly regularly