Merged
Conversation
Evizero
approved these changes
Jun 2, 2021
johnnychen94
commented
Jun 2, 2021
| ImageCore = "0.8.1, 0.9" | ||
| ImageTransformations = "0.5, 0.6, 0.7, 0.8" | ||
| ImageBase = "0.1" | ||
| ImageCore = "0.9" |
Member
Author
There was a problem hiding this comment.
restrict requires ColorVectorSpace to work. I bump the lower bound of ImageCore to 0.9 because it loads ColorVectorSpace JuliaImages/ImageCore.jl#157
Merged
Member
Author
|
Guess @oxinabox might be interested in knowing this since it makes ReferenceTests a lot lighter. julia> @time using ReferenceTests
# before: 2.225183 seconds (5.65 M allocations: 388.105 MiB)
# after: 1.298767 seconds (2.54 M allocations: 174.356 MiB, 7.41% gc time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breaking change is that
vectorinputs now also userestrict; this is unavoidable if we want to reduce the dependencies.