Remove unnecessary version check#287
Merged
timholy merged 2 commits intoJuliaImages:masterfrom Aug 10, 2025
Merged
Conversation
Contributor
kunzaatko
commented
Aug 10, 2025
kunzaatko
commented
- feat(docs): color instead of boxes in padding
- fix: Remove check for Julia version
Color looks better and does not fill so much space. It makes the array more compact looking unlike the boxes around every element.
Reason: The julia version that is checked for is no longer supported in `compat` so the check is not necessary.
Member
|
Since we don't push previews of the docs, any chance you could post a screenshot of what the docs look like before and after? |
Contributor
Author
|
Before: Before: Yeah sorry for that, actually this commit was not intended to be part of the PR. It is already in #285 and I got it mixed up. I am closing that in favour of this one. |
Contributor
Author
|
In my opinion it is cleaner, but if you would suggest that it is not, I can revert that commit. |
Member
|
Seems like a reasonable change to me. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 12 12
Lines 1672 1672
=======================================
Hits 1536 1536
Misses 136 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.