Adds support for specifying kernels using StaticArrays#254
Adds support for specifying kernels using StaticArrays#254zygmuntszpak wants to merge 1 commit intomasterfrom
Conversation
Codecov ReportBase: 78.62% // Head: 91.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
===========================================
+ Coverage 78.62% 91.97% +13.34%
===========================================
Files 12 12
Lines 1062 1657 +595
===========================================
+ Hits 835 1524 +689
+ Misses 227 133 -94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@timholy Please could you take a look when you get a chance |
|
Sorry I missed this PR and the issue. Will check it ASAP. |
| hi = last(ind)+last(pad) | ||
| interval = 1:length(lo:hi) | ||
| T = typeof(T₁) | ||
| I = typeof(SOneTo(length(interval))) |
There was a problem hiding this comment.
This is unfortunately a type-unstable patch: SOneTo{n} where n = length(interval) is runtime information.
IIUC, unless the image itself is also a SMatrix, we can't get a static pad, and thus we can't make it type stable.
The solution to support static array inputs might be converting it back to normal array and unit ranges.
Fixes #252