Conversation
These come from Images.jl and are part of moving most/all code out to make it a meta-package.
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 11 11
Lines 1513 1513
=======================================
Hits 1386 1386
Misses 127 127
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/more_images_cleanout
branch
from
220d27d to
5ed6c11
Compare
johnnychen94
reviewed
Sep 5, 2021
Member
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
As annotated in JuliaImages/Images.jl#971, these may be the last of the moves here (gaussian_pyramid does not seem likely to move)
👍
johnnychen94
approved these changes
Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These come from Images.jl and are part of moving most/all code
out to make it a meta-package.
As annotated in JuliaImages/Images.jl#971, these may be the last of the moves here (
gaussian_pyramiddoes not seem likely to move). Consequently, once this merges we could release a new version, unblocking JuliaImages/ImageSegmentation.jl#72, or we could wait for #214 and/or #225.