Use GraphsInterfaceChecker.jl in the test suite#14
Use GraphsInterfaceChecker.jl in the test suite#14Max0nyshchenko wants to merge 3 commits intoJuliaGraphs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
===========================================
+ Coverage 45.90% 67.46% +21.56%
===========================================
Files 1 1
Lines 61 83 +22
===========================================
+ Hits 28 56 +28
+ Misses 33 27 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
Thank you, this is a very helpful contribution! I have a small suggestion for improving the tests. Could you look into it?
test/test_consistency.jl
Outdated
| @test VNGraphs.graph_chromatic_number(g,0)==3 | ||
|
|
||
| @testset "Graphs.jl Interface Check for VNGraph" begin | ||
| vngs = [VNGraph(12), VNGraph(20), VNGraph(5)] |
There was a problem hiding this comment.
Could you add a few random graphs too? If I am reading this correctly, currently it is being tested only on empty graphs. Something like VNGraph(Graphs.whatever_random_graph_generator(...))
There was a problem hiding this comment.
Sure, makes sense, thank you. I will do that and keep you updated, might take some time for me as I'm not that familiar with these libs (Graphs, VNGraph and VN in C).
There was a problem hiding this comment.
Done, please feel free to check.
2 participants
Solves #3