Remove longer idle timeout#608
Open
IanButterworth wants to merge 1 commit intoJuliaGraphics:masterfrom
Open
Conversation
55b2352 to
caab4a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 57.58% 57.55% -0.04%
==========================================
Files 32 32
Lines 2695 2695
==========================================
- Hits 1552 1551 -1
- Misses 1143 1144 +1
Continue to review full report at Codecov.
|
Collaborator
|
I think there was some reason for this, which applied to windows. Can you test it on Windows? |
Collaborator
Author
|
Ah, ok. I don't have access to windows I'm afraid. If I do I'll try it out. This is far less urgent than the other one IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #607 I think it's reasonable to reduce this timeout because it will still be hit now if a Gtk window is open but idle.
If the reason for the blocking is determined and fixed (given it was reported to not happen on earlier julia versions), the 5s number could be reinstated. I assume the timeout was just made to be 5s when it used to not block..
With a Gtk window open and idle:
Master (v1.1.11)
This PR
Neither case registers any noticeable activity on my cpu monitor