Handle transitive dependencies with Julia master#372
Open
eschnett wants to merge 2 commits intoJuliaGraphics:masterfrom
Open
Handle transitive dependencies with Julia master#372eschnett wants to merge 2 commits intoJuliaGraphics:masterfrom
eschnett wants to merge 2 commits intoJuliaGraphics:masterfrom
Conversation
Author
|
The respective change to Julia's master branch that required this change was reverted. |
giordano
reviewed
Sep 16, 2025
Comment on lines
-31
to
+35
| ccall((:pango_version_string,Cairo.libpangocairo),Cstring,()) )) | ||
| ccall((:pango_version_string,Pango_jll.libpango),Cstring,()) )) | ||
| libgobject_version = VersionNumber( | ||
| unsafe_load(cglobal((:glib_major_version, Cairo.libgobject), Cuint)), | ||
| unsafe_load(cglobal((:glib_minor_version, Cairo.libgobject), Cuint)), | ||
| unsafe_load(cglobal((:glib_micro_version, Cairo.libgobject), Cuint))) | ||
| unsafe_load(cglobal((:glib_major_version, Glib_jll.libglib), Cuint)), | ||
| unsafe_load(cglobal((:glib_minor_version, Glib_jll.libglib), Cuint)), | ||
| unsafe_load(cglobal((:glib_micro_version, Glib_jll.libglib), Cuint))) |
Contributor
There was a problem hiding this comment.
Honestly I think this was right.
Contributor
There was a problem hiding this comment.
And would probably work on Windows, too.
yuyichao
reviewed
Sep 16, 2025
giordano
reviewed
Sep 16, 2025
| libpango_version = VersionNumber(unsafe_string( | ||
| ccall((:pango_version_string,Cairo.libpango),Cstring,()) )) | ||
| ccall((:pango_version_string,Pango_jll.libpango),Cstring,()) )) | ||
| if !Sys.iswindows() |
Contributor
There was a problem hiding this comment.
Try removing this? My hunch is that this was necessary because the wrong library was being referenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The master branch of Julia has this recent change:
This means that a
ccallto libraryAwill not find symbols inA's dependencies any more. For example, looking forpango_version_stringinCairo_jlldoes not work any more. Instead, one has to look for this symbol inPango_jll.This PR updates Cairo in this respect. This change should be backward compatible, i.e. it should work with all earlier versions of Julia as well.