wrap set_metadata and set_custom_metadata#370
Open
jwahlstrand wants to merge 4 commits intoJuliaGraphics:masterfrom
Open
wrap set_metadata and set_custom_metadata#370jwahlstrand wants to merge 4 commits intoJuliaGraphics:masterfrom
set_metadata and set_custom_metadata#370jwahlstrand wants to merge 4 commits intoJuliaGraphics:masterfrom
Conversation
Member
|
@jwahlstrand Seems good to merge (even though old PR). Shall we go ahead? If you don't have commit access here, happy to add you! |
Contributor
Author
Yes, I think this is worth merging, thanks! If I had commit access here I'd be willing to do light maintenance going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap these two methods for setting metadata in PDF surfaces. Also adds status enums that were added in cairo 1.16 and 1.18. Includes tests. Also bumps required Cairo version to 1.18.
Fixes #360