Skip to content

Conversation

@Pangoraw
Copy link
Member

@Pangoraw Pangoraw commented Jul 13, 2024

@adrhill
Copy link

adrhill commented Jul 23, 2024

Related issues: #282, #283

@adrhill
Copy link

adrhill commented Jul 23, 2024

@Pangoraw could you remind me how we tested this locally?

EDIT: GitHub linguist has a guide.

@Pangoraw
Copy link
Member Author

You need nodejs and npm installed:

cd atom-language-julia
npm ci # install dependencies described in package-lock.json (instantiate in julia)
npm run test

@Pangoraw
Copy link
Member Author

One think I am wondering is that maybe we should put the fix in the cson file and remove the json file since Github linguist seems to work fine with cson for now.

@pfitzseb
Copy link
Collaborator

Could also consider moving the source of truth into a template file like the actual julia grammar, but tbf it doesn't really make any sense except for consistency.

@Pangoraw Pangoraw marked this pull request as ready for review April 28, 2025 11:07
@Pangoraw
Copy link
Member Author

Ok, I updated the PR to generate a CSON file from the JSON file. The CSON file will be used by linguist (as it currently is the case).

@pfitzseb pfitzseb merged commit 964286c into JuliaEditorSupport:master Apr 28, 2025
1 check passed
@Pangoraw Pangoraw deleted the multiline-console branch April 28, 2025 12:46
@adrhill
Copy link

adrhill commented Jun 6, 2025

This should be live, but it looks like it didn't fix #282:

julia> function bar(x)
         return x
       end
bar (generic function with 1 method)


julia> d = Dict(
         1 => 'a',
         2 => 'b',
       )
Dict{Int64, Char} with 2 entries:
  2 => 'b'
  1 => 'a'

@adrhill
Copy link

adrhill commented Jun 6, 2025

Maybe I misconfigured something in my linguist PR? github-linguist/linguist#6859

@Pangoraw
Copy link
Member Author

Pangoraw commented Jun 6, 2025

Other changes from the grammar are not updated yet so maybe it may take time to be operational:
Example from #288 :

@+ @& @<| @|> @:: @% x

@adrhill
Copy link

adrhill commented Jun 10, 2025

Maybe this is missing a release/tag? Not sure how linguist works.
https://github.com/JuliaEditorSupport/atom-language-julia/tags

@pfitzseb
Copy link
Collaborator

IIRC tags shouldn't matter at all -- the v9.2 release points to the newest commit in this repo.

@adrhill
Copy link

adrhill commented Jun 24, 2025

Looks like these are still not working:

julia> function bar(x)
         return x
       end
bar (generic function with 1 method)


julia> d = Dict(
         1 => 'a',
         2 => 'b',
       )
Dict{Int64, Char} with 2 entries:
  2 => 'b'
  1 => 'a'
@+ @& @<| @|> @:: @% x

@Pangoraw Pangoraw restored the multiline-console branch October 3, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants