Implement scalar zero dimensional array that is accessed atomically#50
Open
Tokazama wants to merge 2 commits intoJuliaArrays:mainfrom
Open
Implement scalar zero dimensional array that is accessed atomically#50Tokazama wants to merge 2 commits intoJuliaArrays:mainfrom
Tokazama wants to merge 2 commits intoJuliaArrays:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 98.82% 98.96% +0.14%
==========================================
Files 1 1
Lines 85 97 +12
==========================================
+ Hits 84 96 +12
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@nsajko, does this look like an acceptible idea and implementation? |
Member
Author
|
@nsajko, is this something that you would like help maintaining? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides another zero dim type with that is accessed atomically. It is admittedly lacking some API for fing grain control over access order, but I'm not sure if that's desirable at this point since Base Julia has yet to commit to a public API for extending that behavior to reference semantics.