Define Base.show for SArray and MArray.#1021
Open
tpapp wants to merge 1 commit intoJuliaArrays:masterfrom
Open
Define Base.show for SArray and MArray.#1021tpapp wants to merge 1 commit intoJuliaArrays:masterfrom
tpapp wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
This allows SArray and MArray to be printed (show, repr, etc) and read back into an object of the same type. Fixes JuliaArrays#692.
Collaborator
|
I'm not sure that it's preferable to print the content as a tuple though; e.g., A = @SMatrix [1 2; 3 4]would now julia> [A, A, A]
3-element Vector{SMatrix{2, 2, Int64, 4}}:
SMatrix{2,2,Int64}(1, 3, 2, 4)
SMatrix{2,2,Int64}(1, 3, 2, 4)
SMatrix{2,2,Int64}(1, 3, 2, 4)How about instead printing this as |
Collaborator
|
Xref #906 which has some discussion of what to print. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
SArrayandMArrayto be printed (show,repr, etc) and read back into an object of the same type.Fixes #692.