Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 82.78% 78.03% -4.76%
==========================================
Files 1 2 +1
Lines 122 132 +10
==========================================
+ Hits 101 103 +2
- Misses 21 29 +8
Continue to review full report at Codecov.
|
|
@johnnychen94 since this PR aged a bit - are you still interested in this project? I wasn't aware of this effort when I created https://github.com/lazyLibraries/ProductArrays.jl (its publishing is on hold: JuliaRegistries/General#84683) you seem to have thought about the "product of arrays" edge cases too - I have written some tests already but made no performance considerations. Maybe we could combine this effort? EDIT: I would also be very willing to move the ProductArrays.jl project into the JuliaArrays group. This might potentially make more sense than doing this under mappedarrays where few will find them. It also allows for selective import. |
This introduces an intermediate Cartesian product array type that can be used for many operations, depending on how we're going to reduce the item. I'll give two examples that motivate this PR.
In simple words,
ProductedArraysis the array version ofIterators.product:TODO:
Example: ReadonlyMultiMappedArray
Theoretically, we could build the *MultiMappedArray functionality on top of
ProductedArrayand thus simplify the implementation. To minimize the change, I might take a try but won't do it in this PR.Example: pairwise/patch-wise distances