Open
Conversation
Member
|
looks good, about the name, perhaps Would be helpful to throw an explicit error for btw, we need to update docs and README.md, too. |
johnnychen94
approved these changes
Nov 24, 2020
Member
|
If we can solve this by doing in JuliaLang/julia#38558 (comment), I'd very much prefer it to adding a new export here. But if that's not really feasible, then sure, let's do this. But I'd like to hold off a bit and see if someone tackles Generator performance, or at least digs deep enough to understand why it's slower. |
|
I don't think "lazy" is accurate here; it just computes the reduction. Whether there is an intermediate array is not observable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lazy version of
mapreduceusingMappedArrays to get around intermediate allocations (see julia/issues/38558). I'm not sure what to name the function, open to suggestions. The performance improvement is visible: