WIP: Try using an advanced indices object that wraps axes#81
Open
WIP: Try using an advanced indices object that wraps axes#81
Conversation
When asking for the indices of an AxisArray, return a specialized index type that acts just like normal indices, except that we can also get its corresponding Axis and we can dispatch on it.
This _almost_ works, but it's not type stable. The trouble is that the
`IndexAxis` type _sometimes_ wants to know the exact Axis information (like
when used in `similar`), but other times it only cares about the Axis name
(like when choosing the dimensions for a reduction). Specifically, this branch
runs into trouble with this base method:
```
function reduced_indices(inds::Indices{N}, d::Int, rd::AbstractUnitRange) where N
d < 1 && throw(ArgumentError("dimension must be ≥ 1, got $d"))
if d == 1
return (oftype(inds[1], rd), tail(inds)...)
elseif 1 < d <= N
return tuple(inds[1:d-1]..., oftype(inds[d], rd), inds[d+1:N]...)::typeof(inds)
```
I've broken the contract that `oftype`—that is, `convert`—returns an object
of exactly the requested type. But here I simply want a new IndexAxis object
that has the same name and wraps the given `rd` range.
Member
Author
|
Tests pass if I make |
This was referenced May 30, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #58. I like this approach better, and the first commit may be worth doing on its own merits:
The second commit is where I try to implement reductions (redo #56) in terms of the
IndexAxistype. And that doesn't work:I need to call it quits on this for now, but it's definitely better than #58. Any interest in pursuing this further? I'd be curious if this allows more base algorithms to get axis smarts for free, even if we don't use it for reductions.