Skip to content

Conversation

@fuguiKz
Copy link

@fuguiKz fuguiKz commented Jan 2, 2026

Fixes #2375

This is tests-only (no behavior change). It makes a few assertions resilient to platform differences:

  • Build newline-sensitive expected output using cw.Configuration.NewLine/TestStringBuilder (avoids checkout EOL differences).
  • Use an invalid culture name that reliably throws on ICU + Windows NLS.
  • Build expected DateTime output via dob.ToString(culture) to handle ICU's narrow no-break space.

Verification (Linux):

  • dotnet test tests/CsvHelper.Tests/CsvHelper.Tests.csproj -c Release -f net8.0

@fuguiKz
Copy link
Author

fuguiKz commented Jan 3, 2026

Note: the GitHub Actions check suite is currently in an action_required state (fork workflow approval), so CI hasn't executed yet.

Would a maintainer be able to approve and run the workflows for this PR?

This is tests-only (no behavior change). Local verification (Linux): dotnet test tests/CsvHelper.Tests/CsvHelper.Tests.csproj -c Release -f net8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet test net8.0 fails on Linux (newline/culture differences)

1 participant