Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@karmseveeratjisc
Copy link
Contributor

@karmseveeratjisc karmseveeratjisc commented Aug 22, 2025

The purpose of this PR was...

  • Update references to JiscSD to Jisc where makes sense
  • Tweak readme paths to not need full repo path
  • parameterize the github repo location in terraform
  • change conditional in workflows to skip them on jisc/octopus
DONT MERGE until migrated to github enterprise

@@ -1,2 +1,2 @@
# The codeowners for the Octopus repository are
* @JiscSD/Octopus-Dev
* @Jisc/Octopus-Dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a breaker..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we just ignore it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will never make any sense really, we either remove it or use @Jisc (which wont work in jisc-SDG), the side effect is PRs wont automatically get assigned to the team, or we update it once merged and remove it from Jisc/octopus (that will give a conflict though and the repos wont be exact copies)

<img src="https://www.jisc.ac.uk/sites/all/themes/jisc_clean/img/jisc-logo.svg" align="right" width=50 height=50/><h1 align="left">Octopus</h1>

![ui-tasks](https://github.com/JiscSD/octopus/actions/workflows/ui-tasks.yml/badge.svg)
![ui-tasks](/actions/workflows/ui-tasks.yml/badge.svg)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken on branch but I think will work when merged to main (though for Jisc/octopus it will still be broken or will say 'skipped')

Some code has been removed that is no longer needed for the ongoing operation of octopus, but is logged here for future reference:

- Seed data scripts that were used to process the initial data used to populate the database. They were last included in [this commit](https://github.com/JiscSD/octopus/tree/fdd0fc5e0f673a1fe42c4cec0b74fe126be2225b/seed-data-scripts).
- Seed data scripts that were used to process the initial data used to populate the database. They were last included in [this commit](/tree/fdd0fc5e0f673a1fe42c4cec0b74fe126be2225b/seed-data-scripts).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, link will work when merged to main

@karmseveeratjisc karmseveeratjisc marked this pull request as ready for review August 22, 2025 13:43
@karmseveeratjisc karmseveeratjisc requested a review from a team as a code owner August 22, 2025 13:43
Copy link
Contributor Author

@karmseveeratjisc karmseveeratjisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wont merge until migrated anyway

@karmseveeratjisc karmseveeratjisc force-pushed the GEM-21-post-migration-fixes branch from 295416a to d3b220c Compare September 3, 2025 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants